Port to JavaScript #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
- port from Python to JavaScript (by Shirsh Zibbu),
- change from GPLv2+ to Apache-2.0 license (by Shirsh Zibbu),
- most translations lost; only {en,es,fr} are implemented, needs a
translation team to bring forward any matching strings from the
previous version,
- bundle inexplicably includes a generated locale/ directory,
- tested on Ubuntu 18.04 with Sugar 0.112; works fine except for save
image button, which does nothing.
Written-by: SHIRSH ZIBBU <[email protected]>
|
Rebased after master changed. |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
- the button does not work now, cause unknown, - duplicates the function of screenshot key.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We've waited a very long time for a port to GTK+ 3.
This alternative pull request fixes #7 by porting to JavaScript instead of GTK+ 3.
Changes:
port from Python to JavaScript (by @zhirzh Shirsh Zibbu),
change from GPLv2+ to Apache-2.0 license (by @zhirzh Shirsh Zibbu),
Problems:
most translations lost; only {en,es,fr} are implemented; needs a translation team to bring forward any matching strings from the previous version,
bundle inexplicably includes a generated locale/ directory; probably a Sugar Toolkit problem,
tested on Ubuntu 18.04 with Sugar 0.112; works fine except for save image button, which does nothing.
References: